joelthomastrenser/Training-1914-Jan26
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make functions static and const

Browse Source 
- Make controller helper functions static
- Make controller functions which do not modify state const
This commit is contained in:
Joel Thomas
2026-02-20 00:22:48 +05:30
parent 7d98ad508a
commit 284a2a4cc5
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Trenser.FoodDeliveryApp/Trenser.FoodDeliveryApp/FoodDeliveryController.cpp
+4 -4
View File
@@ -18,7 +18,7 @@ Date: 19-02-2026
#include "inputHelper.h" #include "inputHelper.h"
#include "outputHelper.h" #include "outputHelper.h"
bool checkAccess(std::shared_ptr<User> user, const std::string& userWithAccess) static bool checkAccess(std::shared_ptr<User> user, const std::string& userWithAccess)
{ {
if (!user || user->getType() != userWithAccess) if (!user || user->getType() != userWithAccess)
{ {
@@ -28,7 +28,7 @@ bool checkAccess(std::shared_ptr<User> user, const std::string& userWithAccess)
return true; return true;
} }
restaurants::iterator pickRestaurantFromRestaurants(RestaurantOwner& restaurantOwner) static restaurants::iterator pickRestaurantFromRestaurants(RestaurantOwner& restaurantOwner)
{ {
util::clear(); util::clear();
int restaurantIndex = 1, restaurantChoiceIndex; int restaurantIndex = 1, restaurantChoiceIndex;
@@ -212,7 +212,7 @@ void FoodDeliveryController::registerUser()
} }
} }
void FoodDeliveryController::listRestaurants() void FoodDeliveryController::listRestaurants() const
{ {
util::clear(); util::clear();
if (!checkAccess(m_authenticatedUser, "RestaurantOwner")) if (!checkAccess(m_authenticatedUser, "RestaurantOwner"))
@@ -258,7 +258,7 @@ void FoodDeliveryController::addNewRestaurant()
std::cout << "Restaurant " << restaurant->getName() << " with ID " << restaurant->getId() << " created successfully\n"; std::cout << "Restaurant " << restaurant->getName() << " with ID " << restaurant->getId() << " created successfully\n";
} }
void FoodDeliveryController::updateRestaurantStatus() void FoodDeliveryController::updateRestaurantStatus() const
{ {
try try
{ {
Trenser.FoodDeliveryApp/Trenser.FoodDeliveryApp/FoodDeliveryController.h
+2 -2
View File
@@ -24,9 +24,9 @@ public:
void run(); void run();
void login(); void login();
void registerUser(); void registerUser();
void listRestaurants(); void listRestaurants() const;
void addNewRestaurant(); void addNewRestaurant();
void updateRestaurantStatus(); void updateRestaurantStatus() const;
void listRestaurantOrders(); void listRestaurantOrders();
void markOrderReady(); void markOrderReady();
void listMenuItems(); void listMenuItems();