Training-VehicleService-May26

joelthomastrenser/Training-VehicleService-May26

Fork 0

...

Author	SHA1	Message	Date
Jissin Mathew	f3e42a8b17	Merged PR 1172: Payment Management Refactoring - 1930 User Story #1949 User Story #1950 Changes * Added `DataStoreLockGuard` header to project configuration and implemented the class for scoped mutex management. * Refactored `Invoice` model to replace CSV-based serialization with `SerializedInvoice` struct, removing legacy `getHeaders()` and string parsing logic. * Updated `DataStore::getInvoices()` to load records via `loadRecords`, refresh cache, and automatically enrich `Invoice` objects with linked `ServiceBooking` and `InventoryItem` entities. * Implemented `DataStore::saveInvoices()` using the `saveRecords<Invoice, SerializedInvoice>` template for direct shared memory persistence. * Integrated `DataStoreLockGuard` across all critical methods in `PaymentManagementService`: `sendPaymentReminders`, `generateInvoice`, `getInvoices`, `completePayment`, `getAllInvoices`, and `confirmPayment`. * Refactored invoice creation and modification flows to use `createNewRecord` for insertion and explicitly set `RecordState::MODIFIED` before triggering `saveInvoices()`. * Updated data access patterns to extract `.data` pointers from `TrackedRecord` wrappers instead of accessing raw map values directly. * Added validation logic in `getInvoices()` to throw `runtime_error` if referenced ServiceBookings or InventoryItems are missing. * Added necessary header dependencies (`Invoice.h`, `DataStoreLockGuard.h`) in service and store layers. Related work items: #1930, #1949, #1950	2026-06-15 15:27:59 +05:30

Author

SHA1

Message

Date

Jissin Mathew

f3e42a8b17

Merged PR 1172: Payment Management Refactoring - 1930

User Story #1949
User Story #1950

**Changes**

* Added `DataStoreLockGuard` header to project configuration and implemented the class for scoped mutex management.
* Refactored `Invoice` model to replace CSV-based serialization with `SerializedInvoice` struct, removing legacy `getHeaders()` and string parsing logic.
* Updated `DataStore::getInvoices()` to load records via `loadRecords`, refresh cache, and automatically enrich `Invoice` objects with linked `ServiceBooking` and `InventoryItem` entities.
* Implemented `DataStore::saveInvoices()` using the `saveRecords<Invoice, SerializedInvoice>` template for direct shared memory persistence.
* Integrated `DataStoreLockGuard` across all critical methods in `PaymentManagementService`: `sendPaymentReminders`, `generateInvoice`, `getInvoices`, `completePayment`, `getAllInvoices`, and `confirmPayment`.
* Refactored invoice creation and modification flows to use `createNewRecord` for insertion and explicitly set `RecordState::MODIFIED` before triggering `saveInvoices()`.
* Updated data access patterns to extract `.data` pointers from `TrackedRecord` wrappers instead of accessing raw map values directly.
* Added validation logic in `getInvoices()` to throw `runtime_error` if referenced ServiceBookings or InventoryItems are missing.
* Added necessary header dependencies (`Invoice.h`, `DataStoreLockGuard.h`) in service and store layers.

Related work items: #1930, #1949, #1950

2026-06-15 15:27:59 +05:30

Compare commits

1 Commits

develop-sm-payment-management ... f3e42a8b17

Diff Content Not Available

Compare commits

1 Commits develop-sm-payment-management ... f3e42a8b17

Diff Content Not Available

1 Commits

develop-sm-payment-management ... f3e42a8b17