Fix: create missing directories before file creation

Changes:
- Added ensureDirectoryExists() helper using _mkdir()
- Automatically create missing directories before file operations
- Added FileHelper include in FileManager
- Removed placeholder files/README.md

Fixes #1793

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/files/README.md

@@ -1 +0,0 @@
-Place files here.

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/services/PaymentManagementService.cpp

@@ -294,7 +294,7 @@ void PaymentManagementService::generateInvoice(ServiceBooking* booking)
 	{
 		throw std::runtime_error("Invoice generation failed: booking is null.");
 	}
-	double totalLabourCost = 0, totalPartsCost = 0, totalServiceCost = 0;
+	double totalLaborCost = 0, totalPartsCost = 0, totalServiceCost = 0;
 	double discountPercentage = booking->getDiscountPercentage();
 	std::string bookingID = booking->getId();
 	util::Map<std::string, Service*> servicesInTheBookedService = booking->getServices();
@@ -303,9 +303,10 @@ void PaymentManagementService::generateInvoice(ServiceBooking* booking)
 	for (int iterator = 0; iterator < currentJobCards.getSize(); iterator++)
 	{
 		JobCard* currentJobCard = currentJobCards.getValueAt(iterator);
-		if (currentJobCard->getBookingId() == bookingID && currentJobCard->getStatus() != util::ServiceJobStatus::COMPLETED)
+		util::ServiceJobStatus currentJobCardStatus = currentJobCard->getStatus();
+		if (currentJobCard->getBookingId() == bookingID && currentJobCardStatus != util::ServiceJobStatus::CANCELLED && currentJobCardStatus != util::ServiceJobStatus::COMPLETED)
 		{
-			throw std::runtime_error("Invoice generation failed: not all job cards are completed for booking '" + bookingID + "'.");
+			throw std::runtime_error("Invoice generation failed: Not all job cards are completed for booking '" + bookingID + "'.");
 		}
 	}
 	for (int iterator = 0; iterator < servicesInTheBookedService.getSize(); iterator++)
@@ -314,13 +315,13 @@ void PaymentManagementService::generateInvoice(ServiceBooking* booking)
 		if (currentService)
 		{
 			createInventoryItemsMap(completeInventoryItemMapOfBooking, currentService);
-			totalLabourCost += currentService->getLaborCost();
+			totalLaborCost += currentService->getLaborCost();
 			totalPartsCost += util::calculatePartsCost(currentService);
 		}
 	}
-	totalServiceCost = totalLabourCost + totalPartsCost;
+	totalServiceCost = totalLaborCost + totalPartsCost;
 	totalServiceCost -= (totalServiceCost * (discountPercentage / 100));
-	Invoice* invoice = Factory::getObject<Invoice>(bookingID, booking, util::Timestamp(), totalLabourCost, completeInventoryItemMapOfBooking, totalPartsCost, discountPercentage, totalServiceCost, util::Timestamp(), util::PaymentMode::NOTSET, util::PaymentStatus::PENDING);
+	Invoice* invoice = Factory::getObject<Invoice>(bookingID, booking, util::Timestamp(), totalLaborCost, completeInventoryItemMapOfBooking, totalPartsCost, discountPercentage, totalServiceCost, util::Timestamp(), util::PaymentMode::NOTSET, util::PaymentStatus::PENDING);
 	util::Map<std::string, Invoice*>& currentInvoices = m_dataStore.getInvoices();
 	currentInvoices.insert(invoice->getId(), invoice);
 }
@@ -375,7 +376,7 @@ void PaymentManagementService::completePayment(const std::string& invoiceID, uti
 			invoice->setStatus(util::PaymentStatus::COMPLETED);
 			std::string title, message;
 			title = "Payment successful";
-			message = "Payment successful for invoice ID " + invoiceID;
+			message = "Payment successful for Invoice ID " + invoiceID;
 			sendNotification(currentUser, title, message);
 		}
 	}

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/services/ServiceManagementService.cpp

@@ -686,7 +686,7 @@ void ServiceManagementService::cancelTechnicianJobs(const std::string& technicia
             continue;
         }
         std::string title = "Technician Unavailable";
-        std::string message = "Your assigned technician is no longer available. Your booking has been reset to pending, and we will reassign a new technician shortly.";
+        std::string message = "Your assigned technician is no longer available. Your booking has been reset to pending and we will reassign a new technician shortly.";
         processBookingCancellation(booking,
             util::ServiceJobStatus::PENDING,
             title, message, customer,
@@ -1144,7 +1144,7 @@ void ServiceManagementService::completeJob(const std::string& jobID)
 	{
 		currentJob->getBooking()->setStatus(util::ServiceJobStatus::COMPLETED);
 		paymentManagementService.generateInvoice(currentJob->getBooking());
-		std::string title = "Service Booking completed,Invoice Generated.";
+		std::string title = "Service Booking completed. Invoice Generated.";
 		std::string message = "Services completed for the booking and invoice generated.";
 		sendNotification(currentJob->getBooking()->getCustomer(), title, message);
 	}

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/utilities/Enums.h

@@ -137,6 +137,10 @@ namespace util
         {
             return PaymentMode::OFFLINE;
         }
+        if (value == "NOTSET")
+        {
+            return PaymentMode::NOTSET;
+        }
         throw std::invalid_argument("Invalid PaymentMode string");
     }
 

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/utilities/FileHelper.h

@@ -11,10 +11,39 @@ Date: 22-May-2026
 #include <fstream>
 #include <string>
 #include <stdexcept>
+#include <direct.h>
 #include "Vector.h"
 
 namespace util
 {
+    /*
+    Function: ensureDirectoryExists
+    Description: Creates all missing directories present in the given file path.
+                Iteratively parses the path and creates each directory level
+                using _mkdir() before file operations are performed.
+    Parameters:
+        - filePath: const std::string&, relative or absolute file path
+    Returns:
+        - void
+    Throws:
+        - None (_mkdir failures are intentionally ignored if directory already exists)
+    */
+    inline void ensureDirectoryExists(const std::string& filePath)
+    {
+        size_t position = 0;
+
+        while ((position = filePath.find('/', position)) != std::string::npos)
+        {
+            std::string directory = filePath.substr(0, position);
+
+            if (!directory.empty())
+            {
+                (void)_mkdir(directory.c_str());
+            }
+            position++;
+        }
+    }
+
     /*
     Function: loadRecords
     Description: Loads records from a given file path into a vector of strings.
@@ -32,6 +61,7 @@ namespace util
         std::ifstream file(filePath);
         if (!file.is_open())
         {
+            ensureDirectoryExists(filePath);
             std::ofstream newFile(filePath);
             newFile.close();
             file.open(filePath);

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/utilities/FileManager.h

@@ -15,6 +15,7 @@ Date: 22-May-2026
 #include <fstream>
 #include "Vector.h"
 #include "Map.h"
+#include "FileHelper.h"
 
 namespace util
 {
@@ -51,6 +52,7 @@ namespace util
 		std::ifstream file(m_filePath);
 		if (!file.is_open())
 		{
+			ensureDirectoryExists(m_filePath);
 			std::ofstream newFile(m_filePath);
 			newFile.close();
 			file.open(m_filePath);

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/views/AdminMenu.cpp

@@ -434,7 +434,7 @@ void AdminMenu::removeService()
 	if (selectedServiceID != "")
 	{
 		m_controller.removeService(selectedServiceID);
-		std::cout << "Service removed sucessfully.\n\n";
+		std::cout << "Service removed successfully.\n\n";
 	}
 	else
 	{

Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/views/MenuHelper.h

@@ -49,7 +49,7 @@ inline std::string selectServicesToRemove(util::Map<std::string, const Service*>
     std::cout << std::left
         << std::setw(6) << "Index"
         << std::setw(12) << "Service ID"
-        << std::setw(20) << "Name"
+        << std::setw(35) << "Name"
         << std::setw(10) << "Labor Cost"
         << std::endl;
     for (int iterator = 0; iterator < currentServices.getSize(); iterator++)
@@ -62,7 +62,7 @@ inline std::string selectServicesToRemove(util::Map<std::string, const Service*>
         std::cout << std::left
             << std::setw(6) << currentIndex
             << std::setw(12) << currentService->getId()
-            << std::setw(20) << currentService->getName()
+            << std::setw(35) << util::truncateString(currentService->getName(), 30)
             << std::setw(10) << currentService->getLaborCost()
             << std::endl;
         currentServicesMap.insert(currentIndex++, currentService);
@@ -453,12 +453,12 @@ inline const Invoice* selectInvoiceToDisplay(util::Map<std::string, const Invoic
         << std::left
         << std::setw(10) << "Index"
         << std::setw(12) << "BookingID"
-        << std::setw(15) << "VehicleNumber"
+        << std::setw(20) << "Vehicle Number"
-        << std::setw(20) << "TechnicianName"
+        << std::setw(20) << "Technician Name"
-        << std::setw(15) << "TotalAmount"
+        << std::setw(15) << "Total Amount"
-        << std::setw(25) << "InvoiceDate"
+        << std::setw(25) << "Invoice Date"
-        << std::setw(15) << "PaymentStatus"
+        << std::setw(20) << "Payment Status"
-        << std::setw(15) << "PaymentMode"
+        << std::setw(15) << "Payment Mode"
         << std::endl;
     for (int iterator = 0; iterator < currentInvoices.getSize(); iterator++)
     {
@@ -471,11 +471,11 @@ inline const Invoice* selectInvoiceToDisplay(util::Map<std::string, const Invoic
         std::cout << std::left
             << std::setw(10) << currentIndex
             << std::setw(12) << currentInvoice->getBookingId()
-            << std::setw(15) << currentInvoice->getBooking()->getVehicleNumber()
+            << std::setw(20) << currentInvoice->getBooking()->getVehicleNumber()
             << std::setw(20) << ((currentTechnician && !currentTechnician->getName().empty()) ? currentTechnician->getName() : "NULL")
             << std::setw(15) << currentInvoice->getTotalAmount()
             << std::setw(25) << currentInvoice->getInvoiceDate().toString()
-            << std::setw(15) << util::getPaymentStatusString(currentInvoice->getStatus())
+            << std::setw(20) << util::getPaymentStatusString(currentInvoice->getStatus())
             << std::setw(15) << util::getPaymentModeString(currentInvoice->getPaymentMethod())
             << std::endl;
         currentInvoicesIndexMap.insert(currentIndex++, currentInvoice);
@@ -1188,21 +1188,21 @@ inline void displayComboPackagesWithIndex(util::Map<int, const ComboPackage*>& c
         const ComboPackage* currentComboPackage = currentComboPackageIndexMap.getValueAt(iterator);
         if (currentComboPackage == nullptr)
         {
-            throw std::runtime_error("Error accessing the combopackage.\n");
+            throw std::runtime_error("Error accessing the combo package.\n");
         }
         if (iterator == 0)
         {
             std::cout << std::left
                 << std::setw(8) << "Index"
                 << std::setw(10) << "ID"
-                << std::setw(20) << "Package Name"
+                << std::setw(35) << "Package Name"
                 << std::setw(15) << "Discount (%)"
                 << "\n";
         }
         std::cout << std::left
             << std::setw(8) << currentComboPackageIndexMap.getKeyAt(iterator)
             << std::setw(10) << currentComboPackage->getId()
-            << std::setw(20) << currentComboPackage->getPackageName()
+            << std::setw(35) << util::truncateString(currentComboPackage->getPackageName(), 30)
             << std::setw(15) << currentComboPackage->getDiscountPercentage()
             << "\n";
     }