Training-VehicleService-May26

joelthomastrenser/Training-VehicleService-May26

Author	SHA1	Message	Date
Avinash Rajesh	e0e57c00d8	Merged PR 1150: Implement Confirm Payment Functionality Implement Confirm Payment Functionality - Added Controller::getAllInvoices – retrieves all invoices from PaymentManagementService and returns them as a read-only map - Implemented Controller::confirmPayment – delegates payment confirmation for a given invoice ID to PaymentManagementService - Introduced PaymentManagementService::getAllInvoice – provides access to all invoices stored in the datastore - Added PaymentManagementService::confirmPayment – confirms payment for a specific invoice, updates payment date and status, and sends notification - Extended util::PaymentStatus enum – added PAID status and updated string conversion - Integrated AdminMenu::confirmPayment – validates invoice list, filters by status, allows selection, and confirms payment - Updated CustomerMenu::completePayments – uses parameterized status filtering for invoice selection - Enhanced MenuHelper::selectInvoiceFromUserForPayment – accepts requiredStatus parameter for flexible filtering - Adjusted AdminMenu options – added "Confirm Payment" before Logout Related work items: #1797	2026-06-01 14:34:42 +05:30
Avinash Rajesh	a3061f4749	Fixed Reviewed Changes	2026-06-01 14:34:06 +05:30
Avinash Rajesh	bb2fa84316	Implement Confirm Payment Functionality <User Story> Complete Payments - 1797</User Story> <Changes> 1. Added Controller::getAllInvoices - Retrieves all invoices from PaymentManagementService and returns them as a read-only map. 2. Implemented Controller::confirmPayment - Delegates payment confirmation for a given invoice ID to PaymentManagementService. 3. Introduced PaymentManagementService::getAllInvoice - Provides access to all invoices stored in the datastore. 4. Added PaymentManagementService::confirmPayment - Confirms payment for a specific invoice, updates payment date and status, and sends notification. 5. Extended util::PaymentStatus enum - Added PAID status and updated string conversion. 6. Integrated AdminMenu::confirmPayment - Validates invoice list, filters by status, allows selection, and confirms payment. 7. Updated CustomerMenu::completePayments - Uses parameterized status filtering for invoice selection. 8. Enhanced MenuHelper::selectInvoiceFromUserForPayment - Accepts requiredStatus parameter for flexible filtering. 9. Adjusted AdminMenu options - Added "Confirm Payment" before Logout. </Changes> <Test> Acceptance Criteria: 1. Admin selects "Confirm Payment" from menu. - Verify system prompts and displays invoices filtered by status. 2. Admin selects invoice with status = PAID. - Verify payment confirmation updates date, sets status, and sends notification. 3. Admin attempts confirmation with empty invoice list. - Verify error message: "No pending invoices available for confirmation." 4. Customer completes payment. - Verify selection uses util::PaymentStatus::PENDING and payment flow works correctly. 5. Invalid invoice ID entered. - Verify system throws runtime_error with "Payment failed: invalid invoice ID." Precondition: 1. Admin logged into system. 2. At least one invoice exists in datastore. 3. Notification system available. Steps: 1. Navigate to Admin menu → Confirm Payment. 2. Select invoice with PAID status. 3. Confirm payment and check notification. 4. Attempt with empty invoice list. 5. Attempt with invalid invoice ID. </Test> <Review> Sreeja Reghukumar </Review>	2026-06-01 14:20:08 +05:30
Jissin Mathew	f02017ceef	Merged PR 1151: Implement Update Job Status for technician - Renamed Controller and ServiceManagementService methods from completeJob to updateJobStatus for clarity and flexibility. - Enhanced ServiceManagementService::updateJobStatus to support transitions: - STARTED → INPROGRESS - INPROGRESS → COMPLETED (with invoice generation and customer notification). - Added INPROGRESS state to ServiceJobStatus enum and updated string conversion utilities. - Introduced filterJobCards helper to generalize job filtering by status. - Updated TechnicianMenu to allow technicians to select job type (Started/Inprogress) and update status accordingly. - Improved job display to show current status and truncated service names for readability. Related work items: #1798	2026-06-01 14:18:49 +05:30
Jissin Mathew	35efedc481	Fix review comments	2026-06-01 12:17:35 +05:30
Jissin Mathew	6f02f1db44	Implement Update Job Status for technician <UserStory> SER1798: Update Job Status </UserStory> <Changes> 1. Renamed Controller and ServiceManagementService methods from completeJob to updateJobStatus for clarity and flexibility. 2. Enhanced ServiceManagementService::updateJobStatus to support transitions: - STARTED → INPROGRESS - INPROGRESS → COMPLETED (with invoice generation and customer notification). 3. Added INPROGRESS state to ServiceJobStatus enum and updated string conversion utilities. 4. Introduced filterJobCards helper to generalize job filtering by status. 5. Updated TechnicianMenu to allow technicians to select job type (Started/Inprogress) and update status accordingly. 6. Improved job display to show current status and truncated service names for readability. </Changes> <Test> Acceptance Criteria: 1. Technician can select a job with status STARTED and update it to INPROGRESS. 2. Technician can select a job with status INPROGRESS and update it to COMPLETED. 3. Completed bookings automatically generate invoices and send notifications to customers. 4. Job status updates are reflected in the technician’s job list and customer view. Precondition: 1. Technician is logged into the system. 2. Assigned job cards exist with valid statuses (STARTED or INPROGRESS). 3. Datastore and payment service are available. Steps: 1. Navigate to Technician menu and choose "Update Job Status". - Verify that the system prompts for job type selection (Started/Inprogress). 2. Select a job card from the filtered list. - Verify that the job card details are displayed with status. 3. Confirm update. - Verify that the job status changes correctly. 4. For jobs updated to COMPLETED: - Verify that the booking status is updated, invoice is generated, and notification is sent. </Test> <Review> Sreeja Reghukumar, please review </Review> #1798	2026-05-29 13:18:11 +05:30

2 changed files with 5 additions and 5 deletions

									
										Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/views/MenuHelper.h
									
		+4
		-4
	
												View File
												
				@@ -736,7 +736,7 @@ inline std::string selectJobCardToUpdate(util::Map<std::string, const JobCard*>&

				    util::Map<int, const JobCard* > incompleteJobCards;

				    if (assignedJobCards.getSize() == 0)

				    {

				        std::cout << "\nNo jobs available.\n\n";

				        std::cout << "No jobs available.\n\n";

				        return "";

				    }

				    int currentIndex = 1;

				@@ -744,12 +744,12 @@ inline std::string selectJobCardToUpdate(util::Map<std::string, const JobCard*>&

				    if (selectedJobStatusType == util::ServiceJobStatus::STARTED)

				    {

				        util::clear();

				        std::cout << "Select a job to mark as In Progress\n";

				        std::cout << "Select a job to update to Inprogress\n";

				    }

				    else if (selectedJobStatusType == util::ServiceJobStatus::IN_PROGRESS)

				    {

				        util::clear();

				        std::cout << "Select a job to mark as Completed\n";

				        std::cout << "Select a job to update to Completed\n";

				    }

				    else

				    {

				@@ -780,7 +780,7 @@ inline std::string selectJobCardToUpdate(util::Map<std::string, const JobCard*>&

				            incompleteJobCards.insert(currentIndex++, currentJobCard);

				        }

				    }

				    std::cout << "Enter the job index to update: ";

				    std::cout << "Select the Job Card to Update (Index): ";

				    util::read(choice);

				    int selectedJobCardIndex = incompleteJobCards.find(choice);

				    if (selectedJobCardIndex != -1)

									
										Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/views/TechnicianMenu.cpp
									
		+1
		-1
	
												View File
												
				@@ -121,7 +121,7 @@ void TechnicianMenu::updateJobStatus()

				    std::string selectedJobID;

				    util::ServiceJobStatus selectedJobStatus = util::ServiceJobStatus::PENDING;

					util::Map<std::string, const JobCard*> assignedJobCards = m_controller.getJobCardsByUser();

				    std::cout << "Select the type of job you want to update:\n1.Started\n2.In Progress\nChoice: ";

				    std::cout << "Select the type of job you want to update\n1.Started\n2.Inprogress\nChoice: ";

				    util::read(choice);

				    if (choice == 1)

				    {

Compare commits

6 Commits

develop-bugfix-2 .. e0e57c00d8

Compare commits

6 Commits develop-bugfix-2 .. e0e57c00d8

6 Commits

develop-bugfix-2 .. e0e57c00d8