Training-VehicleService-May26

joelthomastrenser/Training-VehicleService-May26

Author	SHA1	Message	Date
joelthomastrenser	dd29c7324f	Fix: Prevent duplicate usernames across all user states Changes: - Updated username duplicate validation to consider all existing users. - Prevented reuse of usernames belonging to deleted/disabled accounts. - Fixed authentication conflicts caused by duplicate usernames. Fixes #1809	2026-06-01 17:40:27 +05:30
joelthomastrenser	17f24b7733	Merged PR 1155: Implement Confirm Payment Functionality - Added Controller::getAllInvoices – retrieves all invoices from PaymentManagementService and returns them as a read-only map - Implemented Controller::confirmPayment – delegates payment confirmation for a given invoice ID to PaymentManagementService - Introduced PaymentManagementService::getAllInvoice – provides access to all invoices stored in the datastore - Added PaymentManagementService::confirmPayment – confirms payment for a specific invoice, updates payment date and status, and sends notification - Extended util::PaymentStatus enum – added PAID status and updated string conversion - Integrated AdminMenu::confirmPayment – validates invoice list, filters by status, allows selection, and confirms payment - Updated CustomerMenu::completePayments – uses parameterized status filtering for invoice selection - Enhanced MenuHelper::selectInvoiceFromUserForPayment – accepts requiredStatus parameter for flexible filtering - Adjusted AdminMenu options – added "Confirm Payment" before Logout Related work items: #1797	2026-06-01 17:34:41 +05:30
Avinash Rajesh	1032fc64bd	Commit `aee6356e`: Implement Confirm Payment Functionality <User Story> Complete Payments - 1797</User Story> <Changes> 1. Added Controller::getAllInvoices - Retrieves all invoices from PaymentManagementService and returns them as a read-only map. 2. Implemented Controller::confirmPayment - Delegates payment confirmation for a given invoice ID to PaymentManagementService. 3. Introduced PaymentManagementService::getAllInvoice - Provides access to all invoices stored in the datastore. 4. Added PaymentManagementService::confirmPayment - Confirms payment for a specific invoice, updates payment date and status, and sends notification. 5. Extended util::PaymentStatus enum - Added PAID status and updated string conversion. 6. Integrated AdminMenu::confirmPayment - Validates invoice list, filters by status, allows selection, and confirms payment. 7. Updated CustomerMenu::completePayments - Uses parameterized status filtering for invoice selection. 8. Enhanced MenuHelper::selectInvoiceFromUserForPayment - Accepts requiredStatus parameter for flexible filtering. 9. Adjusted AdminMenu options - Added "Confirm Payment" before Logout. </Changes> <Test> Acceptance Criteria: 1. Admin selects "Confirm Payment" from menu. - Verify system prompts and displays invoices filtered by status. 2. Admin selects invoice with status = PAID. - Verify payment confirmation updates date, sets status, and sends notification. 3. Admin attempts confirmation with empty invoice list. - Verify error message: "No pending invoices available for confirmation." 4. Customer completes payment. - Verify selection uses util::PaymentStatus::PENDING and payment flow works correctly. 5. Invalid invoice ID entered. - Verify system throws runtime_error with "Payment failed: invalid invoice ID." Precondition: 1. Admin logged into system. 2. At least one invoice exists in datastore. 3. Notification system available. Steps: 1. Navigate to Admin menu → Confirm Payment. 2. Select invoice with PAID status. 3. Confirm payment and check notification. 4. Attempt with empty invoice list. 5. Attempt with invalid invoice ID. </Test> <Review> Sreeja Reghukumar </Review>	2026-06-01 17:30:27 +05:30
joelthomastrenser	cfd1a2b675	Merged PR 1154: Implement Update Job Status for technician - Renamed Controller and ServiceManagementService methods from completeJob to updateJobStatus for clarity and flexibility. - Enhanced ServiceManagementService::updateJobStatus to support transitions: - STARTED → INPROGRESS - INPROGRESS → COMPLETED (with invoice generation and customer notification). - Added INPROGRESS state to ServiceJobStatus enum and updated string conversion utilities. - Introduced filterJobCards helper to generalize job filtering by status. - Updated TechnicianMenu to allow technicians to select job type (Started/Inprogress) and update status accordingly. - Improved job display to show current status and truncated service names for readability. Related work items: #1798	2026-06-01 17:25:28 +05:30
Jissin Mathew	70ec47df04	Fix review comments	2026-06-01 16:49:57 +05:30
Jissin Mathew	2ea77bf9b6	Implement Update Job Status for technician <UserStory> SER1798: Update Job Status </UserStory> <Changes> 1. Renamed Controller and ServiceManagementService methods from completeJob to updateJobStatus for clarity and flexibility. 2. Enhanced ServiceManagementService::updateJobStatus to support transitions: - STARTED → INPROGRESS - INPROGRESS → COMPLETED (with invoice generation and customer notification). 3. Added INPROGRESS state to ServiceJobStatus enum and updated string conversion utilities. 4. Introduced filterJobCards helper to generalize job filtering by status. 5. Updated TechnicianMenu to allow technicians to select job type (Started/Inprogress) and update status accordingly. 6. Improved job display to show current status and truncated service names for readability. </Changes> <Test> Acceptance Criteria: 1. Technician can select a job with status STARTED and update it to INPROGRESS. 2. Technician can select a job with status INPROGRESS and update it to COMPLETED. 3. Completed bookings automatically generate invoices and send notifications to customers. 4. Job status updates are reflected in the technician’s job list and customer view. Precondition: 1. Technician is logged into the system. 2. Assigned job cards exist with valid statuses (STARTED or INPROGRESS). 3. Datastore and payment service are available. Steps: 1. Navigate to Technician menu and choose "Update Job Status". - Verify that the system prompts for job type selection (Started/Inprogress). 2. Select a job card from the filtered list. - Verify that the job card details are displayed with status. 3. Confirm update. - Verify that the job status changes correctly. 4. For jobs updated to COMPLETED: - Verify that the booking status is updated, invoice is generated, and notification is sent. </Test> <Review> Sreeja Reghukumar, please review </Review> #1798	2026-06-01 16:49:56 +05:30
joelthomastrenser	972e353832	Merged PR 1152: Vehicle Service System v1.0.0.0 Features Included: Secure access and session management with role-based authentication Customer and technician account management Service booking and technician assignment Service and combo package management Job card tracking and completion workflow Inventory management and stock monitoring Invoice generation and payment processing Notification management with configurable preferences Observer pattern based alerts for inventory, payments, and service updates	2026-06-01 16:48:25 +05:30

1 changed files with 1 additions and 3 deletions

									
										Trenser.VehicleServiceSystem/Trenser.VehicleServiceSystem/utilities/Validator.cpp
									
		+1
		-3
	
												View File
												
				@@ -116,15 +116,13 @@ bool util::isPasswordValid(const std::string& password)

				 *     usersMap - map of user objects keyed by identifier

				 * Returns:

				 *     bool - true if the username is already in use by an active user, false otherwise

				 * Notes:

				 *     - Only considers users with state util::State::ACTIVE

				 */

				bool util::isUsernameDuplicate(const std::string& username, const util::Map<std::string, User*>& usersMap)

				{

				    int index = usersMap.findIf(

				        [&](const std::string&, User* user)

				        {

				            return (user->getUserName() == username && user->getState() == util::State::ACTIVE);

				            return (user->getUserName() == username);

				        }

				    );

				    return index != -1;

Compare commits

7 Commits

e0e57c00d8 .. develop-bugfix-3

Compare commits

7 Commits e0e57c00d8 .. develop-bugfix-3

7 Commits

e0e57c00d8 .. develop-bugfix-3